#155 Adapt Smarty upper/lower functions to be codesafe (e.g. for Turkish locale) #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. for Turkish locale)
Alexkurd
reviewed
Apr 15, 2020
libs/sysplugins/smarty_internal_compile_private_special_variable.php
Outdated
Show resolved
Hide resolved
…le.php Fixed variable naming typo (thanks!) Co-Authored-By: Alexkurd <7689609+Alexkurd@users.noreply.github.com>
Closed
3 tasks
|
Hello, I need also this fix for a Turkish translation of Wikindx users. Regards, |
|
I am also waiting for this fix. |
|
PHP RFC: Locale-independent case conversion corrects it for PHP 8.2. |
|
@lkppo cool! |
|
Isn't it! I have patched my code with this PR for several months and it is working fine. By the way, I factored with functions ucfirst_ascii(), strtolower_ascii() to minimize the modifications. |
…for translating user string to filenames etc. Fixes smarty-php#155
|
Hi @wisskid, Thanks for merging this PR. My hand patching can go now! Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
ucfirst/lcfirst/strtoupper/strtolowercalls in the code that work with method, class, and variable names. These calls are replaced with equivalents (e.g. usingstrtr) that do not change depending on the system locale. This resolves a problem in particular withtr_TR, for whichstrtolower('I') != 'i'.