Fixed replace modifier by converting encoding if needed #590
Conversation
|
Now, this should be more robust. Turned out, not every UNICODE encoding supported by mbstring regex is equally supported by I've considered using |
|
|
||
| /** @var array Source data for tests, hexed to protect from accidental reencoding */ | ||
| private $data = array( | ||
| "subject" => '4772c3bc6e6577616c64', // "Grünewald" |
There was a problem hiding this comment.
Please add "regex sensitive" characters to the test strings just to prove that your regex quoting and splitting works.
There was a problem hiding this comment.
You mean, characters like {} ?
There was a problem hiding this comment.
These should be added to parent tests, I presume. Since this is regression only test.
There was a problem hiding this comment.
Yes characters like that and: . + * \ / ? ( ) [ ]
Thanks.
|
Bump. This fixes |
`mb_split` will fail if `$pattern` or `$string` contains byte sequences not valid for `mb_regex_encoding()`. Convert both strings and set regex encoding before calling `mb_split()` if needed. Fixes smarty-php#549
|
Opened a related PR #740 against 3.1 maintenance branch. |
|
Related patch #740 into 3.1 branch has been committed recently. Please review this one too. |
|
@wisskid did you backport these changes manually? If so, feel free to close this PR. |
@AnrDaemon yes, I did. 20a8026 |
mb_splitwill fail if$patternor$stringcontains byte sequences not valid formb_regex_encoding().Convert both strings and set regex encoding before calling
mb_split()if needed.Fixes #549