Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space stations should always be identified on Science, Helm & Weapons #8

Closed
kwadroke opened this issue Jul 2, 2013 · 5 comments
Closed

Space stations should always be identified on Science, Helm & Weapons #8

kwadroke opened this issue Jul 2, 2013 · 5 comments

Comments

@kwadroke
Copy link

kwadroke commented Jul 2, 2013

Since Space Stations should be in known places on the map in the universe for friendlies, they should always be marked on each of the stations (Sci, Weapons, Helm).

Another way to possibly handle this, is to have Comms send out a broadcast to all stations and have the stations give their positions upon this request. The screens could then update with the information.
Range could be reduced for this to not identify farther out stations.
@smcameron
Copy link
Owner

There's also a bug that may prevent them from showing up, that may be what you're running into. I think I know the cause of the bug, but haven't settled on the proper way to fix it yet.

@smcameron
Copy link
Owner

Commit b17da8d may fix this issue.

@smcameron
Copy link
Owner

Have made space station data expire more slowly on science screen. Also, there is the possibility of unfriendly stations to consider.

smcameron pushed a commit that referenced this issue Dec 5, 2013
@jv4779 @smcameron
handle the max theoretical triangle clip results without stack crashing.
f945396 
Each triangle might be clipped into two for all six planes, resulting in
64 triangles.  Fixes this bug:

Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1".
Core was generated by `./snis_limited_client'.
Program terminated with signal 11, Segmentation fault.
#0  0x3f7ffff0 in ?? ()
(gdb) bt
#0  0x3f7ffff0 in ?? ()
#1  0x08086409 in clip_triangle (triangles=0xbf8a05e0, vs_out0=0x9221fc0, vs_out1=0x9221908,
    vs_out2=0x9221840) at entity.c:1535
#2  0x0808357e in software_render_entity_triangles (w=0x8ff2840, gc=0x9056ea0, cx=0x99c1e80,
    e=0x9a23df0) at entity.c:509
#3  0x08083c57 in render_entity (w=0x8ff2840, gc=0x9056ea0, cx=0x99c1e80, e=0x9a23df0) at entity.c:605
#4  0x080852e0 in render_entities (w=0x8ff2840, gc=0x9056ea0, cx=0x99c1e80) at entity.c:1094
#5  0x08062a74 in show_mainscreen (w=0x8ff2840) at snis_limited_client.c:4910
#6  0x080797f0 in main_da_expose (w=0x8ff2840, event=0xbf8a0ee8, p=0x0) at snis_limited_client.c:10887
#7  0xb73b28a2 in ?? () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#8  0xb7188484 in g_closure_invoke () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#9  0xb719a0d9 in ?? () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#10 0xb71a1ff5 in g_signal_emit_valist () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#11 0xb71a2453 in g_signal_emit () from /usr/lib/i386-linux-gnu/libgobject-2.0.so.0
#12 0xb74ec413 in ?? () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#13 0xb73b10ff in gtk_main_do_event () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#14 0xb72082bf in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#15 0xb7208262 in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#16 0xb723acd3 in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#17 0xb7202dc4 in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#18 0xb720504f in gdk_window_process_all_updates () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#19 0xb72050c8 in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
#20 0xb71dff88 in ?? () from /usr/lib/i386-linux-gnu/libgdk-x11-2.0.so.0
---Type <return> to continue, or q <return> to quit---
#21 0xb70c6850 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#22 0xb70c8d86 in g_main_context_dispatch () from /lib/i386-linux-gnu/libglib-2.0.so.0
#23 0xb70c9125 in ?? () from /lib/i386-linux-gnu/libglib-2.0.so.0
#24 0xb70c956b in g_main_loop_run () from /lib/i386-linux-gnu/libglib-2.0.so.0
#25 0xb73afb8f in gtk_main () from /usr/lib/i386-linux-gnu/libgtk-x11-2.0.so.0
#26 0x0807bf1d in main (argc=1, argv=0xbf8a1364) at snis_limited_client.c:11811

To reproduce the bug (without this commit, obviously) park the ship inside a
starbase and let the starbase spin around with the main view up.
Usually crashes pretty quickly.
@jv4779
Copy link
Contributor

jv4779 commented Mar 3, 2014

A recent change makes planets and star bases much easier to scan and will pop on sensors if the scanner beam is swept past them. They are not persistently known but now much easier to find at far range.

@smcameron smcameron mentioned this issue Jun 24, 2014
Closed
@smcameron smcameron mentioned this issue Aug 4, 2015
Closed
@hef hef mentioned this issue Aug 9, 2015
Closed
@smcameron
Copy link
Owner

I'm going to go ahead and close this as I think the abovementioned changes address the main complaint. Feel free to re-open and clarify if you don't agree.

@smcameron smcameron mentioned this issue Nov 15, 2017
Closed
@koepnick koepnick mentioned this issue Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smcameron @jv4779 @kwadroke