modify to add to common NoWarn properties in the prop file

smdn · Apr 3, 2024 · 54636a3 · 54636a3
1 parent 71e2e65
commit 54636a3
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -41,7 +41,5 @@ SPDX-License-Identifier: MIT
     />
   </ItemGroup>
 
-  <!-- disables code style/code analysis warnings configured by Smdn.MSBuild.ProjectAssets.Common -->
-  <PropertyGroup>
-  </PropertyGroup>
+  <Import Project="$(MSBuildThisFileDirectory)NoWarn.props" />
 </Project>
diff --git a/src/NoWarn.props b/src/NoWarn.props
@@ -0,0 +1,12 @@
+<!--
+SPDX-FileCopyrightText: 2024 smdn <smdn@smdn.jp>
+SPDX-License-Identifier: MIT
+-->
+<Project>
+  <!-- suppress warnings relevant to XML comment documents as defined by StyleCop Analyzers -->
+  <PropertyGroup>
+    <NoWarn>SA1623;$(NoWarn)</NoWarn> <!-- SA1623: The property's documentation summary text should begin with: 'Gets' -->
+    <NoWarn>SA1629;$(NoWarn)</NoWarn> <!-- SA1629: Documentation text should end with a period -->
+    <NoWarn>SA1642;$(NoWarn)</NoWarn> <!-- SA1642: Constructor summary documentation should begin with standard text -->
+  </PropertyGroup>
+</Project>
diff --git a/src/Smdn.Net.EchonetLite.Appendix/Smdn.Net.EchonetLite.Appendix.csproj b/src/Smdn.Net.EchonetLite.Appendix/Smdn.Net.EchonetLite.Appendix.csproj
@@ -51,11 +51,6 @@ SPDX-License-Identifier: MIT
     <Message Text="MasterData: '%(EmbeddedResource.LogicalName)'" Importance="low"/>
   </Target>
 
-  <!-- disables code style/code analysis warnings configured by Smdn.MSBuild.ProjectAssets.Library -->
-  <PropertyGroup>
-    <NoWarn>SA1623;SA1629;SA1642;$(NoWarn)</NoWarn>
-  </PropertyGroup>
-
   <Target Name="GenerateReadmeFileContent">
     <PropertyGroup>
       <PackageReadmeFileContent><![CDATA[# $(PackageId) $(PackageVersion)

diff --git a/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite.csproj b/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite.csproj
@@ -36,11 +36,6 @@ SPDX-License-Identifier: MIT
     <ProjectOrPackageReference ReferencePackageVersion="1.0.0" Include="..\Smdn.Net.EchonetLite.Appendix\Smdn.Net.EchonetLite.Appendix.csproj" />
   </ItemGroup>
 
-  <!-- disables code style/code analysis warnings configured by Smdn.MSBuild.ProjectAssets.Library -->
-  <PropertyGroup>
-    <NoWarn>SA1623;SA1629;SA1642;$(NoWarn)</NoWarn>
-  </PropertyGroup>
-
   <Target Name="GenerateReadmeFileContent">
     <PropertyGroup>
       <PackageReadmeFileContent><![CDATA[# $(PackageId) $(PackageVersion)