fix warning SA11XX

smdn · Apr 3, 2024 · 6b46b1f · 6b46b1f
1 parent 561553a
commit 6b46b1f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite.csproj b/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite.csproj
@@ -38,7 +38,7 @@ SPDX-License-Identifier: MIT
 
   <!-- disables code style/code analysis warnings configured by Smdn.MSBuild.ProjectAssets.Library -->
   <PropertyGroup>
-    <NoWarn>SA1106;SA1110;SA1113;SA1122;SA1137;SA1208;SA1210;$(NoWarn)</NoWarn>
+    <NoWarn>SA1208;SA1210;$(NoWarn)</NoWarn>
     <NoWarn>SA1309;SA1313;SA1316;SA1402;SA1413;SA1414;$(NoWarn)</NoWarn>
     <NoWarn>SA1505;SA1507;SA1508;SA1513;SA1514;SA1614;SA1623;SA1629;SA1642;$(NoWarn)</NoWarn>
   </PropertyGroup>

diff --git a/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite/EchonetClient.Services.cs b/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite/EchonetClient.Services.cs
@@ -207,7 +207,7 @@ void HandleFrameSetISNA(object? _, (IPAddress address, Frame response) value)
       finally {
         FrameReceived -= HandleFrameSetISNA;
       }
-    };
+    }
 
     FrameReceived += HandleFrameSetISNA;
 
@@ -321,7 +321,7 @@ void HandleFrameSetResOrSetCSNA(object? _, (IPAddress address, Frame response) v
       finally {
         FrameReceived -= HandleFrameSetResOrSetCSNA;
       }
-    };
+    }
 
     FrameReceived += HandleFrameSetResOrSetCSNA;
 
@@ -426,7 +426,7 @@ void HandleFrameGetResOrGetSNA(object? _, (IPAddress address, Frame response) va
       finally {
         FrameReceived -= HandleFrameGetResOrGetSNA;
       }
-    };
+    }
 
     FrameReceived += HandleFrameGetResOrGetSNA;
 
@@ -547,7 +547,7 @@ void HandleFrameSetGetResOrSetGetSNA(object? _, (IPAddress address, Frame respon
       finally {
         FrameReceived -= HandleFrameSetGetResOrSetGetSNA;
       }
-    };
+    }
 
     FrameReceived += HandleFrameSetGetResOrSetGetSNA;
 
@@ -746,7 +746,7 @@ void HandleFrameINFCRes(object? _, (IPAddress address, Frame response) value)
       finally {
         FrameReceived -= HandleFrameINFCRes;
       }
-    };
+    }
 
     FrameReceived += HandleFrameINFCRes;
 

diff --git a/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite/EchonetPropertyExtentions.cs b/src/Smdn.Net.EchonetLite/Smdn.Net.EchonetLite/EchonetPropertyExtentions.cs
@@ -19,14 +19,14 @@ public static string GetDebugString(this EchonetProperty property)
     sb.AppendFormat(provider: null, "0x{0:X2}", property.Spec.Code);
     sb.Append(property.Spec.Name);
     sb.Append(' ');
-    sb.Append(property.CanGet ? "Get" : "");
-    sb.Append(property.Spec.IsGetMandatory ? "(Req)" : "");
+    sb.Append(property.CanGet ? "Get" : string.Empty);
+    sb.Append(property.Spec.IsGetMandatory ? "(Req)" : string.Empty);
     sb.Append(' ');
-    sb.Append(property.CanSet ? "Set" : "");
-    sb.Append(property.Spec.IsSetMandatory ? "(Req)" : "");
+    sb.Append(property.CanSet ? "Set" : string.Empty);
+    sb.Append(property.Spec.IsSetMandatory ? "(Req)" : string.Empty);
     sb.Append(' ');
-    sb.Append(property.CanAnnounceStatusChange ? "Anno" : "");
-    sb.Append(property.Spec.IsStatusChangeAnnouncementMandatory ? "(Req)" : "");
+    sb.Append(property.CanAnnounceStatusChange ? "Anno" : string.Empty);
+    sb.Append(property.Spec.IsStatusChangeAnnouncementMandatory ? "(Req)" : string.Empty);
 
     return sb.ToString();
   }