Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] fix transform_cigar_right_into_insertion if ref_pos == until. #24

Merged
merged 1 commit into from
Sep 19, 2022
Merged

[FIX] fix transform_cigar_right_into_insertion if ref_pos == until. #24

merged 1 commit into from
Sep 19, 2022

Conversation

smehringer
Copy link
Owner

fixes #23

@smehringer smehringer mentioned this pull request Aug 31, 2022
Closed
Irallia
Irallia requested changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only questions of understanding....

by the way, you dont handle X and = in sviper right?
Used instead of M:
'=' means REF and READ are the same.
'X' means REF and READ are not the same.

include/sviper/merge_split_alignments.h Show resolved Hide resolved
include/sviper/merge_split_alignments.h Show resolved Hide resolved
@smehringer
Copy link
Owner Author

by the way, you dont handle X and = in sviper right?

no currently only simple cigar strings are allowed

@smehringer smehringer merged commit ae16974 into master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Irallia Irallia Irallia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault for few SVs
2 participants
@smehringer @Irallia