Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding standard #52

Closed
simPod opened this issue May 7, 2018 · 3 comments
Closed

Coding standard #52

simPod opened this issue May 7, 2018 · 3 comments

Comments

@simPod
Copy link
Contributor

simPod commented May 7, 2018

Would you be interested in setting up unified code style for this library? Personally, I try to use https://github.com/doctrine/coding-standard in every project as IMHO it is the best CS available. The whole Doctrine project is being migrated to it.

We can add it as a check into Travis after it's added. Having coding standard is great because every contribution to the library is consistent with the rest of the codebase and when automated, we don't have to bother with it during code reviews.

I'm willing to add it in next PR if interested.

@isublimity
Copy link
Contributor

Give me time , to approve you prev. PR ;)

I have problem to apply in my projects where use phpClickHouse.

I`m not use and like "coding-standard" -- my team reformat "my code" )

But I will try very hard to accept all your remarks
thanks for the work you've done!

@simPod
Copy link
Contributor Author

simPod commented May 7, 2018

Yup, doesn't relate, will wait until it's merged ;)

my team reformat "my code" )

This is exactly why it's cool to have one.

Will send a proposal afterwards and then it can be decided.

@simPod
Copy link
Contributor Author

simPod commented Jun 3, 2018

Added in 4e9dea8

@simPod simPod closed this as completed Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants