Added auth on Android SDK #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanshg
reviewed
Aug 2, 2023
android/src/main/kotlin/com/smileidentity/smileid/SmileIDPlugin.kt
Outdated
Show resolved
Hide resolved
| @@ -9,7 +9,7 @@ import 'package:flutter/foundation.dart' show ReadBuffer, WriteBuffer; | |||
| import 'package:flutter/services.dart'; | |||
|
|
|||
| enum FlutterJobType { | |||
| biometric_kyc, | |||
| enhanced_kyc, | |||
There was a problem hiding this comment.
Is it possible to assign the actual job type int value here?
There was a problem hiding this comment.
@vanshg refer to the issue I raised on Slack
* Add authentication method to SmileID plugin iOS * Bump native dependency version to 10.0.0-beta04 * update AuthenticationRequest init
vanshg
added a commit
that referenced
this pull request
Aug 9, 2023
* Rename to SmileID (#2) * Authentication support * Asyc Enhanced Kyc iOS (#4) * Add mapper * Add enhancedKyc job type and associated integer value * Update native SmileID dependency to `10.0.0-beta03` * Add `initialize` and `doEnhancedKycAsyc` method calls * Resolve merge conflicts * Asyc Enhanced Kyc iOS (#4) * Add mapper * Add enhancedKyc job type and associated integer value * Update native SmileID dependency to `10.0.0-beta03` * Add `initialize` and `doEnhancedKycAsyc` method calls * Resolve merge conflicts * Added auth on Android SDK (#5) * added auth on android sdk * fixed mapping between flutter and dart code * test gh actions * updated github actions - build iOS and Android * removed ios build * cleaning up action file * cleaning up action file * cleaning up mapper * Cleanup * Dynamic SDK version * Update Gradle version * Update Java version in Github action * Fix AndroidManifest package * added some minor comments * updated tests and updated build file * Add gradle wrapper * Authentication on iOS (#6) * Add authentication method to SmileID plugin iOS * Bump native dependency version to 10.0.0-beta04 * update AuthenticationRequest init * fix podfile * Fix path * Fix Action * Remove develop * Add gradlew * Add gradle wrapper jar * Use flutter and fix tests * Build iOS * Remove iOS Codesigning * Cache Gradle * Fix iOS Build issue * Increase timeout * Separate android and iOS * Another approach * Update timeout --------- Co-authored-by: Vansh Gandhi <vansh@smileidentity.com> Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com> --------- Co-authored-by: Jubril Olambiwonnu <jubrylola@gmail.com> Co-authored-by: Juma Allan <allanjuma@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/10245/add-async-enhanced-kyc-to-flutter-sdk
Summary