Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to x11rb 0.11 #250

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Update to x11rb 0.11 #250

merged 1 commit into from
Nov 20, 2022

Conversation

psychon
Copy link
Contributor

@psychon psychon commented Nov 20, 2022

x11rb switched to some stronger types for certain mask fields. Previously, these masks were represented as integers (e.g. u16). Now, special types are used that also represent the meaning of the mask, e.g. KeyButMask for a mask representing the state of certain keys and buttons.

This commit tries to do as few stuff as possible to fix this API breakage. x11rb provides Into implementations to go from u16 to KeyButMask.

Signed-off-by: Uli Schlachter psychon@znc.in

x11rb switched to some stronger types for certain mask fields.
Previously, these masks were represented as integers (e.g. u16). Now,
special types are used that also represent the meaning of the mask, e.g.
KeyButMask for a mask representing the state of certain keys and
buttons.

This commit tries to do as few stuff as possible to fix this API
breakage. x11rb provides Into implementations to go from u16 to
KeyButMask.

Signed-off-by: Uli Schlachter <psychon@znc.in>
Copy link
Owner

@sminez sminez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @psychon ! Much appreciated 🙂

@sminez sminez merged commit e88199a into sminez:develop Nov 20, 2022
@psychon psychon deleted the update-x11rb branch November 20, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants