Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raw file reader #446

Merged
merged 18 commits into from
Jun 10, 2019
Merged

raw file reader #446

merged 18 commits into from
Jun 10, 2019

Conversation

rmillikin
Copy link
Member

No description provided.

@rmillikin rmillikin mentioned this pull request Jan 8, 2019
Closed
@acesnik
Copy link
Collaborator

acesnik commented Apr 17, 2019

What's going on here?

@acesnik
Copy link
Collaborator

acesnik commented Apr 17, 2019

Oh, this is cool. Have you tried this out in MM locally?

@rmillikin
Copy link
Member Author

there are some problems reading some ITMS data, I think it's a bug in rawfilereader but I haven't resolved it

@rmillikin
Copy link
Member Author

I think we should merge this in soon and try to get all the NuGet stuff working and try it out in MetaMorpheus. The licence that we're required to bundle with this might not pack into NuGet...

RawFileReader has some issues centroiding one of the test datafiles but I don't know how common this is.

It's much faster at file loading than the old system and doesn't require the user to install anything.

@rmillikin
Copy link
Member Author

We can use RawFileReader for opening most files, and if it crashes then we can use MSFileReader as a backup

@rmillikin rmillikin requested a review from zrolfs May 31, 2019 19:46
zrolfs
zrolfs previously approved these changes May 31, 2019
View reviewed changes
@rmillikin
Copy link
Member Author

don't merge this yet, I fixed the problem with reading ITMS files

@rmillikin
Copy link
Member Author

I fixed reading ITMS data. just to be safe, I used MSConvert to convert the three .raw files to .mzML, read in that .mzML along with the .raw, and compared the peak count, intensities, and m/z values. All looks good

@rmillikin rmillikin requested a review from zrolfs June 10, 2019 17:16
@rmillikin rmillikin merged commit e57bcc1 into master Jun 10, 2019
@rmillikin rmillikin deleted the RawFileReader branch June 10, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrolfs zrolfs zrolfs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmillikin @acesnik @zrolfs