Update nearly all nuget packages and .Net to 8.0 #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trishorts
changed the title
trishorts
added
Maintenance
|
please see issue: #781 |
Closed
acesnik
requested changes
May 24, 2024
It is not a problem of net8 compatibility. rather its a problem of older features in these nuget packages that are not supported in the newer release, which would necessitate changes to programs such as MM that use these old features. a focused PR to update each of these two remaining packages should be put on the todo list. |
|
may need to update the nuget website for the target. |
nbollis
approved these changes
Jun 17, 2024
RayMSMS
approved these changes
Jun 17, 2024
acesnik
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.net 6 and 7 no longer have support, which prompted this move to .net 8. To keep up w/ project dependencies and compatibilities, all nuget packages were attempted to be updated.
I generated a local nuget package with this PR and put it into MetaMorpheus. I analyzed 6 Mann files with calibration, averaging, gptmd and search. Results loaded into MetaDraw successfully. I also performed a successful glyco search with test data. I don't see any difficulties integrating this into MetaMorpheus.
OxyPlot.Wpf COULD NOT BE UPDATED
SharpLearning.Optimization COULD NOT BE UPDATED
A close look at the impact of updating these nuget packages on MetaMorpheus and other downstream apps should be performed.
Updating NuUnit was imperfect. The Assert function usage has changed substantially. To avoid massive refactoring, Assert was recast as ClassicAssert. Going forward, we should attempt to use the new Nunit usage.
TargetFramework was updated to 8.0 for all projects in the properties menu of each project in the solution explorer.
The .nuspec was updated to .net 8.0
The github/workflows/dotnet.yml and release.yml were updated to .net 8
coverlet.collector in dotnet.yml updated to -v 6.0.2