Revert intensity pairs pr765 #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 75.25% 75.27% +0.01%
==========================================
Files 195 195
Lines 30484 30482 -2
Branches 3058 3059 +1
==========================================
+ Hits 22942 22944 +2
+ Misses 7027 7024 -3
+ Partials 515 514 -1
|
trishorts
requested review from
Alexander-Sol,
YulingDai,
elaboy,
nbollis,
zhuoxinshi and
RayMSMS
trishorts
added
bug
Maintenance
nbollis
approved these changes
May 28, 2024
elaboy
approved these changes
May 28, 2024
Alexander-Sol
approved these changes
May 28, 2024
elaboy
pushed a commit
to elaboy/mzLib-Fork
that referenced
this pull request
Aug 5, 2024
* correct Within calculation * update unit tests * this is the spot * add space * unused using * vnc * revert IntensityPairs method from pr 765 --------- Co-authored-by: MICHAEL SHORTREED <mrshortreed@wisc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 765 was an attempt to improve the speed of creating intensity pairs for spectrum similarity calculations. The PR had unfortunate side effects. This PR reverts the key method for finding intensity pairs while retaining some inconsequential code improvements such as variable renaming.