chore: add polymorphDafny and polymorphDotnet tasks to Smithy Build Plugin-based SQS TestModel #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 20, 2024 15:15
…ustplaz/gradle-build
Also hook up sqs as a regular test model in CI
robin-aws
reviewed
May 30, 2024
| @@ -1,5 +1,23 @@ | |||
| { | |||
| "version": "1.0", | |||
| "projections": { | |||
There was a problem hiding this comment.
Could we make this listQueuesOnly and actually hook it up as the source in the Gradle build via projectionName = "listQueuesOnly" as above? That way we're actually testing the workflow we're claiming to work now, and TestComAmazonawsSqs.dfy should still work AFAICT.
There was a problem hiding this comment.
Thanks! Only nit is that "listQueuesOnly" is now technically "listQueuesOnlyExceptForAtLeastOneOtherOneBecauseOf#439" :) But it doesn't look like smithy-build.json supports comments. Perhaps we could add a comment to the README of this test model?
There was a problem hiding this comment.
good point, I'll do both.
(JSON in general doesn't support comments, it's kind of a bummer)
added 7 commits
June 10, 2024 14:13
…ustplaz/gradle-build
robin-aws
previously approved these changes
Jun 10, 2024
robin-aws
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #356 (related)
Description of changes: This PR allows the Smithy Build Plugin-based SQS TestModel to be built and structured similarly to the Makefile/CLI based models used elsewhere. This enables some Smithy features which are not supported by the CLI, such as Projections.
Instead of running
make polymorph_dafnyandmake polymorph_dotnet, run./gradlew polymorphDafnyand./gradlew polymorphDotnetto generate types for the respective languages. A Makefile is included, as it is needed to runmake transpile_netandmake test_net, which work as expected when the above commands are executed.NOTE: These changes are not tested in CI. That may be done as part of this PR, or later, depending on what reviewers prefer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.