make it possible to retry any response #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
reviewed
Apr 1, 2024
| @@ -44,6 +44,15 @@ impl ShouldAttempt { | |||
| _ => panic!("Expected this to be the `YesAfterDelay` variant but it was the `{self:?}` variant instead"), | |||
| } | |||
| } | |||
|
|
|||
| /// If this isn't a `No` variant, panic. | |||
| pub fn expect_no(self) { | |||
There was a problem hiding this comment.
Is this method used outside tests?
There was a problem hiding this comment.
No. It's defined in an impl block with #[cfg(feature = "test-util")]. Of course, that's just beyond the fold so it's not clear that that's the case. Thanks GitHub.
ysaito1001
approved these changes
Apr 1, 2024
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
awsdocs/aws-doc-sdk-examples#6021
Description
This change makes it possible to retry requests that were successfully deserialized into an output.
Testing
I wrote a test
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.