Volumeマウントして、そこでデータを一時的に保持します。 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solWat
commented
Jun 11, 2020
notify/notify.py
Outdated
| with open(CONTENT_PATH) as fr: | ||
| file_content = fr.read() | ||
|
|
||
| if file_content != messege: |
There was a problem hiding this comment.
if message の中に、if file_content != messege:があるのが気持ち悪い。これ一個にできんじゃないの
notify/notify.py
Outdated
Comment on lines
63
to
67
| try: | ||
| with open(CONTENT_PATH, mode='x') as f: | ||
| f.write('') | ||
| except FileExistsError: | ||
| pass |
There was a problem hiding this comment.
@solaWat
try , exceptはどういうお気持ちで書いている?
ファイルがない時に88行目でこけないように書いているんかな
There was a problem hiding this comment.
この記事からもらってきました
https://note.nkmk.me/python-file-io-open-with/
むしろファイルがある時にキャッチしてる。
Closed
KAZYPinkSaurus
requested changes
Jun 13, 2020
notify/notify.py
Outdated
Comment on lines
89
to
92
| if messege and messege != file_content: | ||
| with open(CONTENT_PATH, mode='w') as fw: | ||
| fw.write(messege) | ||
| PythonNotify(f"@{user}" + messege + day.upper(), TOKEN) |
There was a problem hiding this comment.
if message の message をなくして 予約なかったら 現在予約なしなどと PythonNotify関数でつぶやいてもらうこと出来る?
notify/notify.py
Outdated
Comment on lines
63
to
69
| try: | ||
| with open(CONTENT_PATH, mode='x') as f: | ||
| f.write('') | ||
| file_content = '' | ||
| except FileExistsError: | ||
| pass | ||
| with open(CONTENT_PATH) as fr: | ||
| file_content = fr.read() |
There was a problem hiding this comment.
例外キャッチ使わずに
if os.path.isfile(CONTENT_PATH):
with open(CONTENT_PATH) as fr:
file_content = fr.read()
else:
file_content = ""
としていみるのもいいかも
There was a problem hiding this comment.
そっちもいいね。
import os
を追加しなきゃいけなかったから、やめといた。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINEの通知がウザすぎたので、その場しのぎですが、差分比較します。
Issue : #1