Support Pain Split #585
Merged
Support Pain Split #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If Protosynthesis / Quark Drive is selected without the necessary conditions to activate, the status is inactive - If the item is changed to booster energy or the correct weather / terrain is set, the status becomes auto select - If the item / weather / terrain are removed, the status reverts to inactive - If a specific stat is selected as the override, that stat is increased by the appropriate multiplier - Overridden selections are not affected by changing item / weather / terrain
Treat Booster Energy as consumed when P/Q is active + smogon#546 nits because Git wouldn't let me push to the branch.
Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md) - [Commits](npm/node-semver@v6.3.0...v6.3.1)
Fixes Spectral Thief stealing negative stat changes, as reported https://www.smogon.com/forums/posts/9748441. Additionally, fixes Spectral Thief not removing positive boosts (particularly Defense boosts) from the target.
In Generation 4, if a Pokemon with the ability Klutz holds an Iron Ball it should still get its Speed dropped. However, Klutz Pokemon holding an Iron Ball won't be grounded. Fixes smogon#560
Duplicate Palafin's sets into Palafin-Hero. Fixes smogon#558
The smoke tester runs PS battles and compares the damage rolls to the calc's. If they don't match, it will print the output to `logs/`. The smoke tester can then be re-ran with the log filename as a CLI argument and it will report each failure in detail. This is still a WIP as can be seen by the TODO comments but it works decently enough now that I decided to commit it to the repo.
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.12 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.2 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
This would be super useful in showdex if merged in calc 👀 |
ForwardFeed
commented
Mar 7, 2024
There was a problem hiding this comment.
Nature's madness does at least does 1hp in damage, it's tiny but the || 1 was justified there
There was a problem hiding this comment.
Yes, but that should be handled in #576. It is irrelevant to this PR which is why I removed it.
|
This PR should be ready. Can you squash it so I can merge? |
|
can't you squash it yourself? like, you're the last one that have worked on it, that makes more sense for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to implement the requested feat #572
Note, i tried to make a full rebase before pushing but failed (i really struggle with git) so there is the other changed of ruination and super fang along side it