Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency tap-junit to v5 #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jun 3, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tap-junit 3.1.2 -> 5.0.0 age adoption passing confidence

Release Notes

dhershman1/tap-junit

v5.0.0

Compare Source

Please report any issues or serliazation that does not follow the below spec for output! Thanks!

BREAKING CHANGES
  • Changed the output generation of tap-junit to follow this spec more closely
    • This means no more floating comments, they are now either in the system-out tag or the message attribute
  • Changed how handling tap comments works, please see the Comments section in the Readme
Improved
  • Bit of re organization of the tool
  • Bumped Docker node and tap versions
Fixed
  • Broken comments on some tap outputs

v4.2.0

Compare Source

Improved
  • Made the error diag more dynamic to handle different types of outputs instead of static and expecting

v4.1.0

Compare Source

New
  • Added the -c argument which sets the testsuite (NOT testsuites) name
    • This should fix #​32 for the jenkins plugin it uses
Improved
  • Tweaked the github bug report template a little to ask for the CLI use of tap-junit
Fixed
  • Removed the old xmlbuilder dependency, woops

v4.0.0

Compare Source

BREAKING CHANGES
  • Converted from tap-out to tap-parser
    • This change means that the xml generated is now "Flat" (see below)
    • This removes the error count as there isn't an event for this anymore
    • Skips are handled WAY better and more naturally with TAP
    • This should flow better with proper tap output
  • If a file extension is set in the command, it will be used for the generated file, if not .xml will be used
  • Error counter removed with new parser
  • The testcase name no longer has test number, the test number is now provided in the id attribute of testcase
New
  • Todo support
  • Added new argument support -p or --pretty use this if you want the xml output to be "pretty" (this is false by default)
Improved
  • Optimized performance from both parsing and serializing
  • Data is built more dynamically, instead of relying on certain keys to exist
  • Better JUnit formatting
  • Moved from xmlbuilder to xmlbuilder2
Flat XML

Now <testsuits> containes only a singular <testsuite> element, within that all of the <testcase> elements now live. Here's an example:

v3 tap-junit output:

<testsuites tests="4" name="suite-name" failures="0" errors="0">
  <testsuite tests="3" failures="0" errors="0" name="1 === 1">
    <testcase name="#&#8203;1 test is equal"/>
    <testcase name="#&#8203;2 test skip extra # SKIP">
      <skipped/>
    </testcase>
    <testcase name="#&#8203;3 should not be equal"/>
  </testsuite>
  <testsuite tests="1" failures="0" errors="0" name="2 === 2">
    <testcase name="#&#8203;4 should be equal"/>
  </testsuite>
  <testsuite tests="0" failures="0" errors="0" name="SKIP skipped test"/>
</testsuites>

v4 tap-junit output:

<testsuites tests="4" name="Tap-Junit" failures="2">
  <testsuite tests="4" failures="2" skipped="1">
    <testcase id="1" name="test is equal"/>
    <testcase id="2" name="test skip extra # SKIP">
      <skipped/>
    </testcase>
    <testcase id="3" name="should not be equal"/>
    <testcase id="4" name="should be equal"/>
  </testsuite>
</testsuites>

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #580 (3cfe7d3) into master (cec6b34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          12       12           
  Lines         525      525           
=======================================
  Hits          460      460           
  Misses         65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec6b34...3cfe7d3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant