Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace async-channel with flume #83

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Replace async-channel with flume #83

merged 2 commits into from
Apr 8, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Apr 8, 2024

This commit replaces async-channel in some tests with flume. It appears
that async-channel doesn't work under MIRI but flume does, so we can
work around this for now by replacing it with flume.

cc smol-rs/async-channel#85

@notgull
tests: Replace async-channel with flume
7fb3b9b 
This commit replaces async-channel in some tests with flume. It appears
that async-channel doesn't work under MIRI but flume does, so we can
work around this for now by replacing it with flume.

cc smol-rs/async-channel#85

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Member Author

notgull commented Apr 8, 2024

I can't emulate the MIRI failure here on my machine unless I run it inside of a Docker container with only three CPUs.

@notgull
tests: ignore barrier::smoke on MIRI as well
68b7182 
Signed-off-by: John Nunley <dev@notgull.net>
@notgull notgull merged commit 5428311 into master Apr 8, 2024
9 checks passed
@notgull notgull deleted the notgull/flume branch April 8, 2024 21:10
@taiki-e
Copy link
Collaborator

taiki-e commented Apr 21, 2024

We got another Miri error today...

https://github.com/smol-rs/async-lock/actions/runs/8769497281/job/24065046417#step:4:219

---- src/once_cell.rs - once_cell::OnceCell<T>::wait_blocking (line 309) stdout ----
Test executable failed (exit status: 1).

stderr:
error: deadlock: the evaluated program deadlocked
  |
  = note: the evaluated program deadlocked
  = note: (no span available)
  = note: BACKTRACE on thread `unnamed-1`:
error: doctest failed, to rerun pass `--doc`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notgull @taiki-e