Skip to content

Commit bad7f1f

Browse files
fatemabgregberge
authored andcommitted
fix(babel-plugin): Use require.resolve instead of relative path resolution (#303)
1 parent 42f55f9 commit bad7f1f

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

packages/babel-plugin/src/__snapshots__/index.test.js.snap

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ exports[`plugin Magic comment should remove only needed comments 1`] = `
3535
return require.resolveWeak(\\"moment\\");
3636
}
3737
38-
return require('path').resolve(__dirname, \\"moment\\");
38+
return eval('require.resolve')(\\"moment\\");
3939
}
4040
4141
};"
@@ -74,7 +74,7 @@ exports[`plugin Magic comment should transpile arrow functions 1`] = `
7474
return require.resolveWeak(\\"moment\\");
7575
}
7676
77-
return require('path').resolve(__dirname, \\"moment\\");
77+
return eval('require.resolve')(\\"moment\\");
7878
}
7979
8080
};"
@@ -115,7 +115,7 @@ exports[`plugin Magic comment should transpile function expression 1`] = `
115115
return require.resolveWeak(\\"moment\\");
116116
}
117117
118-
return require('path').resolve(__dirname, \\"moment\\");
118+
return eval('require.resolve')(\\"moment\\");
119119
}
120120
121121
};"
@@ -157,7 +157,7 @@ exports[`plugin Magic comment should transpile shortand properties 1`] = `
157157
return require.resolveWeak(\\"moment\\");
158158
}
159159
160-
return require('path').resolve(__dirname, \\"moment\\");
160+
return eval('require.resolve')(\\"moment\\");
161161
}
162162
163163
}
@@ -203,7 +203,7 @@ exports[`plugin aggressive import should work with destructuration 1`] = `
203203
return require.resolveWeak(\`./\${foo}\`);
204204
}
205205
206-
return require('path').resolve(__dirname, \`./\${foo}\`);
206+
return eval('require.resolve')(\`./\${foo}\`);
207207
}
208208
209209
});"
@@ -242,7 +242,7 @@ exports[`plugin aggressive import with "webpackChunkName" should replace it 1`]
242242
return require.resolveWeak(\`./\${props.foo}\`);
243243
}
244244
245-
return require('path').resolve(__dirname, \`./\${props.foo}\`);
245+
return eval('require.resolve')(\`./\${props.foo}\`);
246246
}
247247
248248
});"
@@ -281,7 +281,7 @@ exports[`plugin aggressive import without "webpackChunkName" should support comp
281281
return require.resolveWeak(\`./dir/\${props.foo}/test\`);
282282
}
283283
284-
return require('path').resolve(__dirname, \`./dir/\${props.foo}/test\`);
284+
return eval('require.resolve')(\`./dir/\${props.foo}/test\`);
285285
}
286286
287287
});"
@@ -326,7 +326,7 @@ exports[`plugin aggressive import without "webpackChunkName" should support dest
326326
return require.resolveWeak(\`./dir/\${foo}/test\`);
327327
}
328328
329-
return require('path').resolve(__dirname, \`./dir/\${foo}/test\`);
329+
return eval('require.resolve')(\`./dir/\${foo}/test\`);
330330
}
331331
332332
});"
@@ -365,7 +365,7 @@ exports[`plugin aggressive import without "webpackChunkName" should support simp
365365
return require.resolveWeak(\`./\${props.foo}\`);
366366
}
367367
368-
return require('path').resolve(__dirname, \`./\${props.foo}\`);
368+
return eval('require.resolve')(\`./\${props.foo}\`);
369369
}
370370
371371
});"
@@ -404,7 +404,7 @@ exports[`plugin loadable.lib should be transpiled too 1`] = `
404404
return require.resolveWeak(\\"moment\\");
405405
}
406406
407-
return require('path').resolve(__dirname, \\"moment\\");
407+
return eval('require.resolve')(\\"moment\\");
408408
}
409409
410410
});"
@@ -443,7 +443,7 @@ exports[`plugin simple import in a complex promise should work 1`] = `
443443
return require.resolveWeak(\\"./ModA\\");
444444
}
445445
446-
return require('path').resolve(__dirname, \\"./ModA\\");
446+
return eval('require.resolve')(\\"./ModA\\");
447447
}
448448
449449
});"
@@ -482,7 +482,7 @@ exports[`plugin simple import should transform path into "chunk-friendly" name 1
482482
return require.resolveWeak(\\"../foo/bar\\");
483483
}
484484
485-
return require('path').resolve(__dirname, \\"../foo/bar\\");
485+
return eval('require.resolve')(\\"../foo/bar\\");
486486
}
487487
488488
});"
@@ -521,7 +521,7 @@ exports[`plugin simple import should work with * in name 1`] = `
521521
return require.resolveWeak(\`./foo*\`);
522522
}
523523
524-
return require('path').resolve(__dirname, \`./foo*\`);
524+
return eval('require.resolve')(\`./foo*\`);
525525
}
526526
527527
});"
@@ -560,7 +560,7 @@ exports[`plugin simple import should work with template literal 1`] = `
560560
return require.resolveWeak(\`./ModA\`);
561561
}
562562
563-
return require('path').resolve(__dirname, \`./ModA\`);
563+
return eval('require.resolve')(\`./ModA\`);
564564
}
565565
566566
});"
@@ -599,7 +599,7 @@ exports[`plugin simple import with "webpackChunkName" comment should use it 1`]
599599
return require.resolveWeak(\\"./ModA\\");
600600
}
601601
602-
return require('path').resolve(__dirname, \\"./ModA\\");
602+
return eval('require.resolve')(\\"./ModA\\");
603603
}
604604
605605
});"
@@ -638,7 +638,7 @@ exports[`plugin simple import with "webpackChunkName" comment should use it even
638638
return require.resolveWeak(\\"./ModA\\");
639639
}
640640
641-
return require('path').resolve(__dirname, \\"./ModA\\");
641+
return eval('require.resolve')(\\"./ModA\\");
642642
}
643643
644644
});"
@@ -677,7 +677,7 @@ exports[`plugin simple import without "webpackChunkName" comment should add it 1
677677
return require.resolveWeak(\\"./ModA\\");
678678
}
679679
680-
return require('path').resolve(__dirname, \\"./ModA\\");
680+
return eval('require.resolve')(\\"./ModA\\");
681681
}
682682
683683
});"

packages/babel-plugin/src/properties/resolve.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default function resolveProperty({ types: t, template }) {
66
return require.resolveWeak(ID)
77
}
88
9-
return require('path').resolve(__dirname, ID)
9+
return eval('require.resolve')(ID)
1010
`
1111

1212
function getCallValue(callPath) {

0 commit comments

Comments
 (0)