perf: use more performant url join impl (#353)

hulkish · gregberge · commit c3fbbef53b5f · 2019-06-05T10:20:10.000+02:00
diff --git a/packages/server/src/util.js b/packages/server/src/util.js
@@ -17,7 +17,10 @@ export const smartRequire = modulePath => {
   return eval('module.require')(modulePath)
 }
 
-export const joinURLPath = (...paths) => {
-  const cleanPaths = paths.map(path => path.replace(/\/$/, ''))
-  return cleanPaths.join('/')
+export const joinURLPath = (publicPath, filename) => {
+  if (publicPath.substr(-1) === '/') {
+    return `${publicPath}${filename}`
+  }
+
+  return `${publicPath}/${filename}`
 }

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,10 @@ export const smartRequire = modulePath => {`
`17`	`17`	`return eval('module.require')(modulePath)`
`18`	`18`	`}`
`19`	`19`
`20`		`-export const joinURLPath = (...paths) => {`
`21`		`- const cleanPaths = paths.map(path => path.replace(/\/$/, ''))`
`22`		`- return cleanPaths.join('/')`
	`20`	`+export const joinURLPath = (publicPath, filename) => {`
	`21`	`+ if (publicPath.substr(-1) === '/') {`
	`22`	+ return `${publicPath}${filename}`
	`23`	`+ }`
	`24`	`+`
	`25`	+ return `${publicPath}/${filename}`
`23`	`26`	`}`