Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--summary does not report rule for missing files #2216

Closed
sirno opened this issue Apr 17, 2023 · 0 comments · Fixed by #2217
Closed

--summary does not report rule for missing files #2216

sirno opened this issue Apr 17, 2023 · 0 comments · Fixed by #2217
Labels
bug Something isn't working

Comments

@sirno
Copy link
Contributor

sirno commented Apr 17, 2023

Snakemake version

Version 7.25.0

Describe the bug

snakemake --summary does not indicate the rule for files with status missing and plan update required under unknown conditions. This is inconsistent with the report from snakemake -n which indicates that snakemake was indeed able to evaluate the rule to be applied, i.e. all missing files are counted and accounted to their respective rules.Os

Minimal example

rule all:
    input:
        expand("data/touched_{i}", i=range(10))

rule touch:
    output:
        "data/touched_{i}"
    shell:
        "touch {output}"

Output of snakemake --summary:

output_file	date	rule	version	log-file(s)	status	plan
data/touched_0	-	-	-	-	missing	update pending
data/touched_1	-	-	-	-	missing	update pending
data/touched_2	-	-	-	-	missing	update pending
data/touched_3	-	-	-	-	missing	update pending
data/touched_4	-	-	-	-	missing	update pending
data/touched_5	-	-	-	-	missing	update pending
data/touched_6	-	-	-	-	missing	update pending
data/touched_7	-	-	-	-	missing	update pending
data/touched_8	-	-	-	-	missing	update pending
data/touched_9	-	-	-	-	missing	update pending

Output of snakemake -n --quiet:

Building DAG of jobs...
Job stats:
job      count    min threads    max threads
-----  -------  -------------  -------------
all          1              1              1
touch       10              1              1
total       11              1              1
@sirno sirno added the bug Something isn't working label Apr 17, 2023
@sirno sirno changed the title --summary does not report rule --summary does not report rule for missing files Apr 17, 2023
@sirno sirno changed the title --summary does not report rule for missing files fix: --summary does not report rule for missing files Apr 17, 2023
@sirno sirno changed the title fix: --summary does not report rule for missing files --summary does not report rule for missing files Apr 17, 2023
johanneskoester pushed a commit that referenced this issue Apr 28, 2023
### Description

This PR fixes #2216, by using the job rule name as derived in the dag.

I am not entirely sure what the persistence class does here, but I guess
it somehow caches the jobname in the .snakemake directory when the rule
is run. This probably leads to incorrect summaries before the rules have
been cached, which does not seem like the intended behavior of the
summary option.

### QC

* [x] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [x] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant