Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: avoid superflous mtime checks when the same file is referred to by multiple jobs #2284

Merged
merged 2 commits into from Jun 16, 2023

Conversation

johanneskoester
Copy link
Contributor

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit eb6e2e1 into main Jun 16, 2023
8 checks passed
@johanneskoester johanneskoester deleted the perf/avoid-superfluous-mtime-checks branch June 16, 2023 06:49
johanneskoester pushed a commit that referenced this pull request Jun 16, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.28.3](v7.28.2...v7.28.3)
(2023-06-16)


### Bug Fixes

* Detect pandas availability to select serializer
([#2300](#2300))
([e08a771](e08a771))


### Performance Improvements

* avoid superflous mtime checks when the same file is referred to by
multiple jobs
([#2284](#2284))
([eb6e2e1](eb6e2e1))


### Documentation

* update docs for azbatch and dockerhub ref
([#2298](#2298))
([908dbf1](908dbf1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vsoch pushed a commit to vsoch/snakemake that referenced this pull request Jun 20, 2023
… by multiple jobs (snakemake#2284)

### Description

<!--Add a description of your PR here-->

### QC
<!-- Make sure that you can tick the boxes below. -->

* [x] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [x] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).
vsoch pushed a commit to vsoch/snakemake that referenced this pull request Jun 20, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.28.3](snakemake/snakemake@v7.28.2...v7.28.3)
(2023-06-16)


### Bug Fixes

* Detect pandas availability to select serializer
([snakemake#2300](snakemake#2300))
([e08a771](snakemake@e08a771))


### Performance Improvements

* avoid superflous mtime checks when the same file is referred to by
multiple jobs
([snakemake#2284](snakemake#2284))
([eb6e2e1](snakemake@eb6e2e1))


### Documentation

* update docs for azbatch and dockerhub ref
([snakemake#2298](snakemake#2298))
([908dbf1](snakemake@908dbf1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant