Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs for azbatch and dockerhub ref #2298

Merged
merged 11 commits into from Jun 14, 2023
Merged

Conversation

jakevc
Copy link
Contributor

@jakevc jakevc commented Jun 13, 2023

Description

  • Patches the Azure Batch Executor docs to include instructions for generating an SAS token
  • Updates the Azure Batch Executor test to pull docker image from the latest snakemake release

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@jakevc jakevc changed the title update docs and dockerhub ref docs: update docs and dockerhub ref Jun 13, 2023
@jakevc jakevc added the documentation Improvements or additions to documentation label Jun 13, 2023
@vsmalladi
Copy link

@jakevc also did some updates in my pr #2299 maybe we can merge the two?

@jakevc
Copy link
Contributor Author

jakevc commented Jun 14, 2023

@vsmalladi Nice! I will integrate your changes into mine... only because then the tests will actually run correctly (mine has access to the secrets needed for the CI).

vsmalladi added a commit to vsmalladi/snakemake that referenced this pull request Jun 14, 2023
@jakevc jakevc changed the title docs: update docs and dockerhub ref docs: update docs for azbatch and dockerhub ref Jun 14, 2023
@johanneskoester
Copy link
Contributor

There also seems to be a bug in the executor: https://github.com/snakemake/snakemake/actions/runs/5265546472/jobs/9518335244#step:20:310

@johanneskoester
Copy link
Contributor

Maybe caused by an api breakage?

@github-actions
Copy link
Contributor

Please format your code with black: black snakemake tests/*.py.

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jakevc
Copy link
Contributor Author

jakevc commented Jun 14, 2023

Maybe caused by an api breakage?

fixed!

@johanneskoester johanneskoester merged commit 908dbf1 into main Jun 14, 2023
8 checks passed
@johanneskoester johanneskoester deleted the fix/bump-docs branch June 14, 2023 18:25
johanneskoester pushed a commit that referenced this pull request Jun 16, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.28.3](v7.28.2...v7.28.3)
(2023-06-16)


### Bug Fixes

* Detect pandas availability to select serializer
([#2300](#2300))
([e08a771](e08a771))


### Performance Improvements

* avoid superflous mtime checks when the same file is referred to by
multiple jobs
([#2284](#2284))
([eb6e2e1](eb6e2e1))


### Documentation

* update docs for azbatch and dockerhub ref
([#2298](#2298))
([908dbf1](908dbf1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
vsoch pushed a commit to vsoch/snakemake that referenced this pull request Jun 20, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.28.3](snakemake/snakemake@v7.28.2...v7.28.3)
(2023-06-16)


### Bug Fixes

* Detect pandas availability to select serializer
([snakemake#2300](snakemake#2300))
([e08a771](snakemake@e08a771))


### Performance Improvements

* avoid superflous mtime checks when the same file is referred to by
multiple jobs
([snakemake#2284](snakemake#2284))
([eb6e2e1](snakemake@eb6e2e1))


### Documentation

* update docs for azbatch and dockerhub ref
([snakemake#2298](snakemake#2298))
([908dbf1](snakemake@908dbf1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants