Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Google Service Accounts and GCE VM network configuration #2318

Merged
merged 12 commits into from
Jul 26, 2023

Conversation

johntbates
Copy link
Contributor

Description

feat: Adds support for Google Service Accounts and GCE VM network configuration

  • Google Life Sciences executors can now be run with user-specified service accounts
  • As a result, application default credentials can be used on GCE without requiring the GOOGLE_APPLICATION_CREDENTIALS environment variable.
  • Added flags to support user-specified service accounts, VM network and subnetwork
  • Updated tests and documentation

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

Thanks a lot!

@johanneskoester johanneskoester merged commit 2b754aa into snakemake:main Jul 26, 2023
3 checks passed
johanneskoester pushed a commit that referenced this pull request Jul 26, 2023
🤖 I have created a release *beep* *boop*
---


##
[7.31.0](v7.30.2...v7.31.0)
(2023-07-26)


### Features

* Add support for Google Service Accounts and GCE VM network
configuration
([#2318](#2318))
([2b754aa](2b754aa))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants