-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On windows, the new storage plugin functionality seems to fail to properly match s3 objects between input and output of rules #2473
Comments
Yes. Just merge it. I will be happy to help fix the issue on Windows if I can. However, I will not have time to really look into it until next weekend. |
Thank you so much! PR is merged, the problematic test is Line 655 in fb65c33
|
@johanneskoester. What do you suspect. Is it snakemake itself or the new storage-plugin that is causing the bug? |
@johanneskoester. I gave it a look while the kids were sleeping. But it took a me a while to get into the code base again. Just getting the test running locally proved difficult. Turns out that "Git for Windows" have reorganized its internal unix tools so they are no longer on path (Things like "cp", "touch", "cat" etc.) I guess it works in the cloud because the GitHub actions VM comes prepackaged with all the tools MSYS2 tools on path. I fixed that and got the tests suite running, but for some reason a few tests still fail for me:
I will disregard that for now and begin looking at the However, is there any documentation or discussion on how the new |
… paths (#2519) Fixes: #2473 ### QC <!-- Make sure that you can tick the boxes below. --> * [ ] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [ ] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
Snakemake version
Snakemake 8.0 (in development)
Describe the bug
On windows, the new storage plugin functionality seems to fail to properly match s3 objects between input and output of rules
Logs
Minimal example
This can for example be observed when activating the test case test_storage on windows.
@melund, your help would be greatly appreciated! (at the moment, the test fails in PR #5440, but I will merge that PR ASAP even before this is fixed in order to proceed with the finalization of Snakemake 8.0).
The text was updated successfully, but these errors were encountered: