Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--conda-create-envs-only causes an AttributeError #2556

Closed
jlanga opened this issue Dec 21, 2023 · 5 comments · Fixed by #2652
Closed

--conda-create-envs-only causes an AttributeError #2556

jlanga opened this issue Dec 21, 2023 · 5 comments · Fixed by #2652
Labels
bug Something isn't working

Comments

@jlanga
Copy link

jlanga commented Dec 21, 2023

Snakemake version
8.0.1

Describe the bug
The --conda-create-envs-only causes an AttributeError

Logs

Traceback (most recent call last):
  File "/home/jlanga/.miniconda3/envs/snake8/lib/python3.12/site-packages/snakemake/cli.py", line 1948, in args_to_api
    dag_api.conda_create_envs()
  File "/home/jlanga/.miniconda3/envs/snake8/lib/python3.12/site-packages/snakemake/api.py", line 636, in conda_create_envs
    self.workflow_api._workflow.conda_create_envs()
  File "/home/jlanga/.miniconda3/envs/snake8/lib/python3.12/site-packages/snakemake/workflow.py", line 981, in conda_create_envs
    ignore_incomplete=self.execution_settings.ignore_incomplete,
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ignore_incomplete'

Minimal example

snakemake --conda-create-envs-only

Additional context
Happens in Python 3.12 and 3.11. Doesn't happen in Snakemake 7.20.0.
Happens also when using the snakemake/snakemake-github-action.

@jlanga jlanga added the bug Something isn't working label Dec 21, 2023
@mdrago98
Copy link

I was able to replicate the same issue calling the --dags flag on snakemake 8.0.1 python version 3.11. Assuming something happened to the self.execution_settings.ignore_incomplete attribute and will affect all flags referencing this attribute

@jlanga
Copy link
Author

jlanga commented Jan 8, 2024

Fixed for me in 8.1.0

@jlanga jlanga closed this as completed Jan 8, 2024
@gdrolet
Copy link

gdrolet commented Jan 10, 2024

I have the same error as OP using 8.1.0.

Reverting back to my old version (7.22), the error is gone. Issue should be reopened.

@jlanga jlanga reopened this Jan 12, 2024
@johnne
Copy link

johnne commented Jan 14, 2024

I have the same error on 8.0.0, and 8.1.2.

@Nicolas-Fernandez
Copy link

Nicolas-Fernandez commented Jan 18, 2024

Hi dear all,
Same in 8.2.1
Thank for your help, have a nice day,
Best,
Nicolas

MarwanMabrouk pushed a commit to MarwanMabrouk/snakemake that referenced this issue Jan 26, 2024
johanneskoester pushed a commit that referenced this issue Jan 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.4.0](v8.3.2...v8.4.0)
(2024-01-29)


### Features

* add cols argument to lookup function; fix various minor bugs on
cluster systems
([#2651](#2651))
([ca7a602](ca7a602))


### Bug Fixes

* batch bug [#2643](#2643)
([#2650](#2650))
([2ecb21b](2ecb21b))
* f-string in a more robust style?
([#2649](#2649))
([2a50dc0](2a50dc0))
* set ignore_incomplete to False in create_conda_envs
([#2653](#2653))
([4834a42](4834a42))
* Setting the value of ignore_incomplete Fixes
[#2556](#2556)
([#2654](#2654))
([05dac64](05dac64))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants