Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not pass snakefile as metadata when wms monitor flag is used #2573

Merged
merged 2 commits into from Jan 15, 2024

Conversation

fgypas
Copy link
Member

@fgypas fgypas commented Jan 3, 2024

Description

Fixes #2390 by not providing a Snakefile as it is anyway not used in the web server.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@fgypas fgypas added the bug Something isn't working label Jan 3, 2024
@fgypas fgypas changed the title fix: do no pass snakefile when wms monitor flag is used fix: do no pass snakefile as metadata when wms monitor flag is used Jan 3, 2024
@fgypas fgypas changed the title fix: do no pass snakefile as metadata when wms monitor flag is used fix: do not pass snakefile as metadata when wms monitor flag is used Jan 4, 2024
@fgypas fgypas requested a review from vsoch January 4, 2024 14:58
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit 13b3205 into snakemake:main Jan 15, 2024
34 checks passed
johanneskoester pushed a commit that referenced this pull request Jan 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.1.3](v8.1.2...v8.1.3)
(2024-01-15)


### Bug Fixes

* bug with preemptible rules
([#2616](#2616))
([c6d7141](c6d7141))
* do not pass snakefile as metadata when wms monitor flag is used
([#2573](#2573))
([13b3205](13b3205))
* use default group settings if not execution workflow (fixes attribute
error occurring with --report)
([#2617](#2617))
([21e9964](21e9964))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError exception thrown with --wms-monitor pointing to Panoptes server
2 participants