Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use default group settings if not execution workflow (fixes attribute error occurring with --report) #2617

Merged
merged 3 commits into from Jan 15, 2024

Conversation

johanneskoester
Copy link
Contributor

This avoids the error AttributeError: 'NoneType' object has no attribute 'local_groupid', e.g. occurring when trying to create a report

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester johanneskoester changed the title fix: use default group settings if not execution workflow (fixes reports) fix: use default group settings if not execution workflow (fixes attribute error occurring with --report) Jan 15, 2024
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit 21e9964 into main Jan 15, 2024
34 checks passed
@johanneskoester johanneskoester deleted the fix/default-group-settings branch January 15, 2024 08:38
johanneskoester pushed a commit that referenced this pull request Jan 15, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.1.3](v8.1.2...v8.1.3)
(2024-01-15)


### Bug Fixes

* bug with preemptible rules
([#2616](#2616))
([c6d7141](c6d7141))
* do not pass snakefile as metadata when wms monitor flag is used
([#2573](#2573))
([13b3205](13b3205))
* use default group settings if not execution workflow (fixes attribute
error occurring with --report)
([#2617](#2617))
([21e9964](21e9964))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant