fix: Setting the value of ignore_incomplete Fixes #2556 #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarwanMabrouk
changed the title
|
Looks like this covers the PR I opened yesterday, #2654, but you've covered a few more functions. I'm still not sure if If you don't mind, I can add the tests from my PR to this one and then close mine? Can also incorporate your changes into mine, don't think the order of operations matters. |
johanneskoester
approved these changes
Jan 29, 2024
|
Thank you so much! |
|
johanneskoester
pushed a commit
that referenced
this pull request
Jan 29, 2024
🤖 I have created a release *beep* *boop* --- ## [8.4.0](v8.3.2...v8.4.0) (2024-01-29) ### Features * add cols argument to lookup function; fix various minor bugs on cluster systems ([#2651](#2651)) ([ca7a602](ca7a602)) ### Bug Fixes * batch bug [#2643](#2643) ([#2650](#2650)) ([2ecb21b](2ecb21b)) * f-string in a more robust style? ([#2649](#2649)) ([2a50dc0](2a50dc0)) * set ignore_incomplete to False in create_conda_envs ([#2653](#2653)) ([4834a42](4834a42)) * Setting the value of ignore_incomplete Fixes [#2556](#2556) ([#2654](#2654)) ([05dac64](05dac64)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setting
ignore_incompletetoTrueto fix a few functions that run beforeExecutionSettingsis initialized becauseExecutionSettingsis only initialized inexecute_workflowfixes:
which all run before
execute_workflowQC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).