New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snakemake 8 not usable with Slurm clusters offering GPUs #2701
Comments
As far as I can see, a profile with
gets accepted on submission, but fails in a job context, right? |
I will prepare a simple PR. |
That is correct. |
As workflow users may put a space before a hyphen, the previous fix might fail! As hyphens may not occur in any Pyhton variable checking for hyphens is more stable.
As users may enter a space before the hyphen, we just lstrip the value.
Should this PR #2711 fix the issue?
I have tried the change by updating Snakemake to 8.4.12
default-resources:
...
slurm_extra: "'--gres=gpu:1'" it fails when it gets a slot in the Slurm queue
default-resources:
...
slurm_extra: "--gres=gpu:1" it fails right away
|
Please try: However, it seems to me that this is only a partial fix. Human-readable runtime specs in a workflow profile still raise an error. |
I am not sure if I understand. This is exactly what I used and described in the previous message. Am I missing some detail? |
In these threads there might be someone overlooking something and this someone might be me. Such things just happen. I only looked at point two, when writing. Sorry. I am, however, confused altogether regarding the parsing state right now. Therefore, I will submit a few additional test cases. |
does this issue still exist? I'm still running into it with a profile like this:
downgrading to snakemake 7 seems to fix the issue |
no, the issue is fixed. I do not run into any issues in this regard. If you run into any, please report in the slurm-executor repo - be sure to be running snakemake +v8.6 |
this should work!
|
In order to use GPUs one needs to be able to ask Slurm for a GPU.
The usual way to do this is
--gres gpu:1
or--gpus 1
switches, which both go toslurm_extra
in the Snakemake profile.slurm_extra
does not work in Snakemake 8, it is rejected.You might be aware of the issue, but maybe you think it is already fixed.
I am creating this issue as a reminder.
Prior discussion snakemake/snakemake-executor-plugin-slurm#18
Some workflows really need GPUs, otherwise they do not finish in a feasible time.
The text was updated successfully, but these errors were encountered: