fix: various bug fixes for resource parsing #2711
Merged
+53
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
johanneskoester
pushed a commit
that referenced
this pull request
Feb 20, 2024
🤖 I have created a release *beep* *boop* --- ## [8.4.12](v8.4.11...v8.4.12) (2024-02-20) ### Bug Fixes * constrain dependencies to match conda experience ([#2710](#2710)) ([d9a7a13](d9a7a13)) * various bug fixes for resource parsing ([#2711](#2711)) ([d1daf0b](d1daf0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cmeesters
reviewed
Feb 21, 2024
| @@ -536,7 +544,8 @@ def generic_callable(val, threads_arg, **kwargs): | |||
| f"'{val}'.\n" | |||
| " String arguments may need additional " | |||
| "quoting. E.g.: --default-resources " | |||
| "\"tmpdir='/home/user/tmp'\".", | |||
| "\"tmpdir='/home/user/tmp'\" or " | |||
| "--set-resources \"compute1:slurm_extra='--nice=100'\".", | |||
There was a problem hiding this comment.
is this hard-coded compute1 as a rule name really intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).