Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix technical bugs in resource-scope documentation #1784

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

pvandyken
Copy link
Contributor

@pvandyken pvandyken commented Jul 27, 2022

Description

I discovered a few mistakes in the .rst documentation leading to incorrect display. Hopefully this fixes the problems. Is there any way to preview the site before merging?

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@pvandyken pvandyken changed the title Fix technical bugs in resource-scope documentation fix: Fix technical bugs in resource-scope documentation Jul 27, 2022
A few features that only started in v7.11 are labelled as such
@pvandyken
Copy link
Contributor Author

Also labelled two other sections as belonging to Snakemake 7.11

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

No preview so far. One could generate an artifact after the docs are built in github actions and display it here for download though.

@johanneskoester johanneskoester merged commit 878420c into snakemake:main Jul 28, 2022
@pvandyken pvandyken deleted the docs-mistake branch July 28, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants