fix: Limit python versions for testing #2204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Python3.10 collections.Callable to collections.abc.Callable, which [breaks nose](nose-devs/nose#1122). Seems that for now testing can only be done with earlier versions. In the long run some other testing solution might be needed.
|
Kudos, SonarCloud Quality Gate passed!
|
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
maxim-h
changed the title
|
Actually we use pytest, not nose. It works fine with 3.10. Do we still mention or recommend nose somewhere? |
|
Ah, ok. |
2 tasks
johanneskoester
pushed a commit
that referenced
this pull request
Apr 28, 2023
### Description As mentioned in #2204 Contributing guide still refers to `nosetest`. * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting with Python3.10 collections.Callable moved to collections.abc.Callable, which breaks nose.
Seems that for now testing can only be done with earlier versions.
In the long run some other testing solution might be needed.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).