Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remote GS builds too many inventories; io:collect_mtime always uses uncached mtime #2266

Merged
merged 10 commits into from Jun 30, 2023
Merged

fix: remote GS builds too many inventories; io:collect_mtime always uses uncached mtime #2266

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3b90fa3
add '--show-failed-logs` to executor args
cademirch Dec 6, 2022
b5a226a
Revert "add '--show-failed-logs` to executor args"
cademirch Dec 6, 2022
0c0b1a6
Merge branch 'main' of https://github.com/cademirch/snakemake into main
cademirch May 17, 2023
8efceb8
Merge branch 'main' of https://github.com/cademirch/snakemake into main
cademirch May 17, 2023
0b1a080
: get_inventory_parent should return bucket/subfolder
cademirch May 18, 2023
b24b25a
use path.mtime to use iocache
cademirch May 18, 2023
2e467b4
Use fstring
cademirch Jun 5, 2023
64075a0
Use mtime uncached here
cademirch Jun 5, 2023
1b7638b
Merge branch 'main' into fix-gls-iocache
johanneskoester Jun 16, 2023
913d18c
Merge branch 'main' into fix-gls-iocache
johanneskoester Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion snakemake/remote/GS.py
View file
Open in desktop
Expand Up @@ -194,7 +194,7 @@ async def inventory(self, cache: snakemake.io.IOCache):
# === Implementations of abstract class members ===

def get_inventory_parent(self):
return self.bucket_name
return f"{self.bucket_name}/{os.path.dirname(self.blob.name)}"

@retry.Retry(predicate=google_cloud_retry_predicate)
def exists(self):
Expand Down