Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix #2698 #2714

Merged
merged 4 commits into from Feb 24, 2024
Merged

docs: fix #2698 #2714

merged 4 commits into from Feb 24, 2024

Conversation

cmeesters
Copy link
Contributor

Description

"Just" a documentation update:

  • deleted obsolete --cluster references in the tutorial section
  • rephrased MPI section

References to SLURM Executor Plugin and snakemake-profiles in both changed paragraphs.

@johanneskoester today, I am not particularly good with words, but I hope its ok-ish.

- removed `--cluster` paragraphs in tutorial
- introduced link to SLURM executor docs and snakemake-profiles
re-shuffeled description on MPI usage, introduced links
to SLURM executor plugin and snakemake-profiles
@cmeesters
Copy link
Contributor Author

PS this PR addresses issue #2698

PPS I just hoped to get my way with the semantic commits ...

@cmeesters
Copy link
Contributor Author

At #2698 it has been commented that the API docs are missing, too. Not sure: Have these been auto-generated in the past @johanneskoester ?

@johanneskoester johanneskoester changed the title Docs/fix 2698 docs: fix #2698 Feb 21, 2024
@johanneskoester
Copy link
Contributor

Yes, they are auto-generated. They are also there, but need some polishing: https://snakemake-api.readthedocs.io/en/stable/

And a link from the main docs as well.

docs/snakefiles/rules.rst Outdated Show resolved Hide resolved
@johanneskoester johanneskoester merged commit 508080b into main Feb 24, 2024
2 of 3 checks passed
@johanneskoester johanneskoester deleted the docs/fix_2698 branch February 24, 2024 09:27
Copy link
Contributor

Please format your code with black: black snakemake tests/*.py.

Copy link

sonarcloud bot commented Feb 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

johanneskoester pushed a commit that referenced this pull request Feb 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.5.1](v8.5.0...v8.5.1)
(2024-02-24)


### Documentation

* api docs polishing
([58a6a13](58a6a13))
* fix [#2698](#2698)
([#2714](#2714))
([508080b](508080b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants