馃悰 Fix bug to run Kubernetes jobs with large files #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a Kubernetes job, the source files will be uploaded as Kubernetes secrets. However, they have a size limit of 1MB. See: kubernetes/kubernetes#19781
The
KubernetesExecutor.run()
method has already taken this into account by checking secret file sizes. Yet before invokingrun()
, at initialization the methodregister_secret()
will be called, which should also check the file size, otherwise anOSError: (32, 'EPIPE')
may be thrown.We can solve the problem by checking source file sizes in
register_secret()
, skipping large ones, with warning messages.Bug description
Version: snakemake v5.15.0
Scenario: call snakemake from a git directory which contains files larger than 1MB, with
--kubernetes
arguments. For example:Output: