Updating google_lifesciences.py #653
Conversation
We want to update the GLS executor to use the helper script provided in the repository, instead of the one in a gist. The gist is here https://gist.githubusercontent.com/vsoch/f5a6a6d1894be1e67aa4156c5b40c8e9/raw/a4e9ddbeba20996ca62745fcd4d9ecd7bfa3b311/gls.py in case anyone wants to do a comparison!
|
Kudos, SonarCloud Quality Gate passed!
|
|
That's the change here - the script is changed from a gist to one provided with the repository! It's easiest to do a wget, because it would even work if Snakemake happens to not be installed for some reason. If we distribute with snakemake, we would need to (in bash) somehow discover where the install is, and then that specific script, and then possibly copy it where we need it. Does this approach not work? Can you walk me through what you have in mind? |
|
I think you are right. I was thinking that, if it is part of the snakemake package, it could be pushed as a file, but that makes little sense, because you need the script to download it then, a hen and egg problem. So, all fine here, thanks. |
|
🐔 + 🥚 problems! :) Always hiding in unexpected places. Thanks! |
We want to update the GLS executor to use the helper script provided in the repository, instead of the one in a gist. The gist is here https://gist.githubusercontent.com/vsoch/f5a6a6d1894be1e67aa4156c5b40c8e9/raw/a4e9ddbeba20996ca62745fcd4d9ecd7bfa3b311/gls.py in case anyone wants to do a comparison!