Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding future note about panoptes monitoring #800

Merged
merged 3 commits into from
Dec 16, 2020

Conversation

vsoch
Copy link
Contributor

@vsoch vsoch commented Dec 14, 2020

This is a tiny note to add to the monitor docs to prepare for the refactor of Panoptes as a logger proper. Of course when some new version is developed, I'll come back for another PR to make the changes and further update these docs! This is related to #799

Signed-off-by: vsoch vsochat@stanford.edu

Signed-off-by: vsoch <vsochat@stanford.edu>
@vsoch
Copy link
Contributor Author

vsoch commented Dec 14, 2020

@johanneskoester there aren't any changes to code here so I'm wondering why this is coming up. It looks like the core error is:

ERROR    snakemake.logging:logging.py:402 AttributeError in line 6 of /tmp/snakemake-wdokifod/Snakefile:
'_patch' object has no attribute 'is_local'

And this might be because of referencing a property on a mocked class? https://stackoverflow.com/questions/31709792/patching-a-class-yields-attributeerror-mock-object-has-no-attribute-when-acce. Was this working before?

@vsoch
Copy link
Contributor Author

vsoch commented Dec 14, 2020

I'm running it again in case it was transient, but likely not.

Signed-off-by: vsoch <vsochat@stanford.edu>
@johanneskoester
Copy link
Contributor

@johanneskoester there aren't any changes to code here so I'm wondering why this is coming up. It looks like the core error is:

ERROR    snakemake.logging:logging.py:402 AttributeError in line 6 of /tmp/snakemake-wdokifod/Snakefile:
'_patch' object has no attribute 'is_local'

And this might be because of referencing a property on a mocked class? https://stackoverflow.com/questions/31709792/patching-a-class-yields-attributeerror-mock-object-has-no-attribute-when-acce. Was this working before?

it seems to be an incompatibility in moto. I hope it will go away with a future release. For now, I skip the test.

@johanneskoester johanneskoester merged commit da70010 into snakemake:master Dec 16, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants