Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak: getPlacement resize & scroll #2118

Closed
WizardCM opened this issue Oct 17, 2018 · 1 comment
Closed

Memory leak: getPlacement resize & scroll #2118

WizardCM opened this issue Oct 17, 2018 · 1 comment

Comments

@WizardCM
Copy link

bootstrap-select/js/bootstrap-select.js

Line 1803 in fecf381

$(window).on('resize scroll', function () {

These event hooks are not namespaced (so I can't clean them up myself), and are never removed by Bootstrap Select itself. The more times you create and destroy Bootstrap Select, the more stack up.
caseyjhol added a commit that referenced this issue Oct 25, 2018
@caseyjhol
namespace window event listeners and remove when destroy is called (#…
ed51e69 
…2118). Only call getPlacement and scroll functions on resize/scroll if the menu is open (#2105, #2034)
@caseyjhol
Copy link
Member

Released in v1.13.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WizardCM @caseyjhol