Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a check for window to avoid breaking node envs #998

Merged
merged 2 commits into from
May 12, 2024
Merged

added a check for window to avoid breaking node envs #998

merged 2 commits into from
May 12, 2024

Conversation

fffbbbccc
Copy link
Contributor

Fixes
addresses #992
Changes proposed in this pull request:

  • added a check for window to avoid breaking node envs

@fffbbbccc fffbbbccc mentioned this pull request May 11, 2024
Closed
ChaituVR
ChaituVR approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit ab51c3d into snapshot-labs:master May 12, 2024
@ChaituVR ChaituVR linked an issue May 12, 2024 that may be closed by this pull request
ReferenceError: window is not defined while trying to vote with snapshot.js #992
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: window is not defined while trying to vote with snapshot.js
2 participants
@fffbbbccc @ChaituVR