min should apply to votes according to strategy @ snapshot block number #110
Comments
|
I'll look on this today, but to begin with, it will use the current block number not the snapshot of the proposal. |
This was referenced Sep 24, 2020
daywiss
pushed a commit
that referenced
this issue
Nov 27, 2023
samuveth
pushed a commit
that referenced
this issue
Nov 29, 2023
* add activate osnap button Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * bubble emits up Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add is osnap enabled prop Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add safe app link Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add disclaimer Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * reduce text size Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * update safe app url Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix tailwind mistake Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use params object Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add is osnap enabled check Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add new osnap plugin Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use presence of plugin to determine if is enabled Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * move enable osnap logic out of settings Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * switch to composition api Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * update types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove batch logic from transactions Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove multisend from contract interaction Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove multisend from transfer funds Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add correct token type Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * refactor transfer nft Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * refactor raw transaction input Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add model value and config types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add model value types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add transactions by treasury address type Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add high level interface types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove batches logic Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * wire up module address query Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * refactor raw transaction Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * refactor contract interaction Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * only allow one safe Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * refactor proposal component Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename prop for clarity Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * auto select safe on mount Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix reference error Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix collectable fetch bug Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix short name in type Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove redundant labels Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add types for token fetch logic Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix typo Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use update for event name Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add update transaction event to raw Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add placeholder data display Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add types for transfer nft Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename is proposal to is read only Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add contract interaction validation Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * clear parameter on method change Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add individual parameter examples Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use disabled inputs for read only Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove unused files Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove legacy function code Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * organize exports Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename for clarity Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use method name instead of index Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use existing data if it exists Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use list of one collectable when is read only Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * re-add activate osnap button Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * only show osnap button when plugin is present Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * handle undefined assets Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * make transaction fields possibly undefined Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * disable dropdown when read only Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add loading safes state Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use modal select for transaction type Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add transaction builder styles Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add style variant for proposal Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * re-add osnap modal Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use separate page for read only Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix import error Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * make address required Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use transfer funds as default Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add legacy plugin warning Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * update is osnap enabled on window focus Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * extract safe link logic Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use modal for safe select Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add comments for types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove redundant functions Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename for clarity Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove weird thing Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * apply formatting Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * revert original changes Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * undo old changes Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add end newlines to match old Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * update import Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * undo accidental rename Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * handle legacy plugin Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add no safes warning Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * undo wrong change Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove old redundant styles Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add doc comments for functions Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add proposal details types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add comments Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add address input types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add amount input types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename component for clarity Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add tokens modal types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add tokens modal item types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename for clarity Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * extract submit proposal modal to component Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add error notifications Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * simplify proposal state Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * split steps into components Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove redundant action button state Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * use shared header Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * don't format amount on change Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add assertion failed in oo state Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove balance logic from details query Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * separate proposal details chain call Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * refactor proposal state fetching Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * warn about disputed proposals Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * run prettier Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * remove unused types Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * move get paged events to events Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add doc comments Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * rename for clarity Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * do not show edit plugin modal when is osnap Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * add readme Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * apply formatting Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * fix wrong function interface Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * format Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> * merge latest from origin Signed-off-by: david <david@umaproject.org> * fix network id interpretation, and crash when in space.members * update changes from master * fix: spacing changes on outcomes page for osnap plugin (#103) * feat: improve look and feel of transaction builder in osnap (#104) * fix: formatting Signed-off-by: david <david@umaproject.org> * fix: reset to snapshot's standard 42px height (#105) * feat: uma 1936 add dark mode osnap buttons (#106) * fix: cosmetic issues (#107) * fix: remove extra spacing (#108) * fix: change osnap activated to use snapshot's primary blue color (#109) * fix: font colors in configure osnap modal (#111) * fix: simplify osnap transactions (#112) * fix: shorten module address in snapshot proposal transaction (#110) * fix: change osnap opt in instructions container and checkbox (#113) * fix: remove View on IPFS link (#114) * fix: show pending notification on signed tx (#115) * fix: remove custom inactive osnap button styles (#116) * fix: remove request transaction execution warning message (#117) --------- Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com> Signed-off-by: david <david@umaproject.org> Co-authored-by: ryanwolhuter <dev@ryanwolhuter.com> Co-authored-by: Gerhard Steenkamp <51655063+gsteenkamp89@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
min should apply to votes according to strategy @ snapshot block number
Actual behavior
min applies to balanceOf of token of proposal signer address
Steps to reproduce the behavior
create a proposal from account that has enough votes according to strategies to exceed min
it does not show up
The text was updated successfully, but these errors were encountered: