Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace eth-ens-namehash with @ensdomains/eth-ens-namehash #1420

Merged
merged 2 commits into from
Jan 7, 2022
Merged

replace eth-ens-namehash with @ensdomains/eth-ens-namehash #1420

merged 2 commits into from
Jan 7, 2022

Conversation

mktcode
Copy link
Contributor

@mktcode mktcode commented Jan 6, 2022 •
edited
Loading

@ensdomains/eth-ens-namehash is a fork of eth-ens-namehash maintained by the ENS org.

It makes this patch obsolete: https://github.com/snapshot-labs/snapshot/blob/develop/patches/idna-uts46-hx%2B2.3.1.patch

bonustrack
bonustrack approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound good

@samuveth
Copy link
Contributor

samuveth commented Jan 7, 2022

Awesome!

@samuveth samuveth merged commit 6384fad into develop Jan 7, 2022
@samuveth samuveth deleted the mkt/replace-ens-namehash-dependency branch January 7, 2022 12:30
@ChaituVR ChaituVR mentioned this pull request Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mktcode @samuveth @bonustrack @ChaituVR