few updates #159
Merged
few updates #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into revamp_tests
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.35 to 17.0.36. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bs/sx-core into generalize_addresses
pscott
approved these changes
Jun 14, 2022
Comment on lines
+1
to
+4
| # Generalized type used to represent addresses in Snapshot X. Eg Ethereum, Starknet, etc. | ||
| struct Address: | ||
| member value : felt | ||
| end |
There was a problem hiding this comment.
Should this be called lib/address ? I find it odd to have a filename be general_address and the actual object be Address ?
There was a problem hiding this comment.
hmm yeah its not ideal, just thought that people would assume its a Starknet address if its called address.cairo
| .commit( | ||
| getCommit(BigInt(space.address), BigInt(getSelectorFromName('vote')), proposeCalldata) | ||
| ); // Wrong selector | ||
| .commit(getCommit(BigInt(space.address), PROPOSE_SELECTOR, proposeCalldata)); // Wrong selector |
There was a problem hiding this comment.
This was supposed to be VOTE_SELECTOR, not PROPOSE_SELECTOR I think (since the comment says "Wrong selector") ?
There was a problem hiding this comment.
The test was testing that revert case (ie authentication fails if the wrong hash is committed) - the comment is just referring to what I changed to cause it to fail.
Comment on lines
+21
to
41
| let spaceAddress: bigint; | ||
| let executionHash: string; | ||
| let metadataUri: bigint[]; | ||
| let proposerAccount: Account; | ||
| let proposerAddress: string; | ||
| let usedVotingStrategies1: bigint[]; | ||
| let userVotingParamsAll1: bigint[][]; | ||
| let executionStrategy: bigint; | ||
| let executionParams: bigint[]; | ||
| let ethBlockNumber: bigint; | ||
| let proposeCalldata: bigint[]; | ||
|
|
||
| // Additional parameters for voting | ||
| let voterAccount: Account; | ||
| let voterAddress: string; | ||
| let proposalId: bigint; | ||
| let choice: Choice; | ||
| let usedVotingStrategies2: bigint[]; | ||
| let userVotingParamsAll2: bigint[][]; | ||
| let voteCalldata: bigint[]; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few updates. Got a bit carried away, will do on separate PRs next time
Allow handling of both Ethereum and Starknet addresses in the space contract and voting strategies.
Switched to a felt to uint256 function from cairo common
Fixed vulnerability in authenticators where the library function
executecould be called directly.Added starknet.js deployment script for a space contract with a number of modules activated. Can call deployment script with
yarn deploy:goerli.Deployment info in
./deployments/goerli1.json