Improved array storage handling in Space contract #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orland0x
changed the title
pscott
approved these changes
Jun 24, 2022
| @@ -368,7 +368,7 @@ export async function singleSlotProofSetup(block: any, proofs: any) { | |||
| const minVotingDuration = BigInt(0); | |||
| const maxVotingDuration = BigInt(2000); | |||
| const votingStrategies: bigint[] = [BigInt(singleSlotProofStrategy.address)]; | |||
| const votingStrategyParams: bigint[][] = [[proofInputs.ethAddressFelt, BigInt(1)]]; | |||
| const votingStrategyParams: bigint[][] = [[proofInputs.ethAddressFelt, BigInt(0)]]; // For the aave erc20 contract, the balances mapping has a storage index of 0 | |||
There was a problem hiding this comment.
Mind expanding on that? It is common? Is it expected?
There was a problem hiding this comment.
for the test we are proving aave balances, and in their specific erc20 implementation the slot index of the balances[] mapping is 0. Not always o though, which is annoying as each DAO using it will have to work out their own slot index. Ive got a rough tool to do it in the evm-slot-key-verification repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we modify how voting parameter arrays are stored in the space contract. Now, the first parameter of the array is the length of the array and then the following parameters are the elements.
This now enables us to remove the voting parameter array associated with a voting strategy when a voting strategy is removed, which we add in this PR.
This closes #188