-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ethereum Signature Verification #203
Conversation
…into add_eth_auth
@Orland0x wtf test is failing in the StorageProof side of things? Any idea of what's going on here? I guess it has to do with a cairo version maybe? https://github.com/snapshot-labs/sx-core/runs/7044640255?check_suite_focus=true |
Hmmm |
This reverts commit 78ed759.
…into add_eth_auth
This PR:
EthSig.cairo
authenticator which verifies a classic Ethereum signature (r, s, v
) over an EIP-712 hash (hashes types are intests/starknet/helper/types.ts
).felt_to_uint256
to usesplit_felt
from thecommon
libraryNote:
metadataURI
is NOT added to thePropose
type becausestrings
are a little bit hash in Cairo. This should come in a later update :) (tracking issue: #202)Closes #30 !! 🥳