Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata uri to eth sig #258

Merged
merged 8 commits into from
Aug 6, 2022
Merged

Add metadata uri to eth sig #258

merged 8 commits into from
Aug 6, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Aug 4, 2022

Adds metadata URI (and support for any string) to the EIP-712 object used to authenticate users.

Basically, the idea is to use IntsSequence (represented in LE, not in BE).
On the Cairo side of things:

  • Use keccak_bigend to hash the input
  • Add metadata_uri_string_len as an argument to the propose function.

On the TS side of things (offchain):

Closes #202

@pscott pscott requested a review from Orland0x August 4, 2022 15:24
@pscott
Copy link
Contributor Author

pscott commented Aug 4, 2022

Need to merge snapshot-labs/sx.js#48 and update the version on this PR to have it work I think :)

@pscott pscott force-pushed the add_metadata_uri_to_eth_sig branch from 8b73d65 to 0797897 Compare August 4, 2022 16:09
Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pscott pscott merged commit 8a05bf8 into develop Aug 6, 2022
@Orland0x Orland0x deleted the add_metadata_uri_to_eth_sig branch November 25, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadataURI to the Propose type
2 participants