Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better asserts in voting lib #264

Merged
merged 3 commits into from
Aug 7, 2022
Merged

Use better asserts in voting lib #264

merged 3 commits into from
Aug 7, 2022

Conversation

pscott
Copy link
Contributor

@pscott pscott commented Aug 5, 2022

Supersedes #90 and #206
Closes #85

@pscott pscott requested a review from Orland0x August 5, 2022 15:16
@Orland0x
Copy link
Contributor

Orland0x commented Aug 5, 2022

looks good, found one more one:
https://github.com/snapshot-labs/sx-core/blob/1551fbd2e2ee44220aa61af1a79bfcdd64bedc82/contracts/starknet/lib/voting.cairo#L440

If proposal doesnt exist then the vote will fail with "Voting has not started yet" so we should add an assert not zero

@Orland0x Orland0x merged commit 5bff7cb into develop Aug 7, 2022
@Orland0x Orland0x deleted the use_better_asserts branch November 25, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean some code
2 participants