Voting strategy indexing #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
approved these changes
Aug 24, 2022
| @@ -149,7 +149,7 @@ describe('Controller Actions', () => { | |||
| user.address, | |||
| utils.intsSequence.IntsSequence.LEFromString(''), | |||
| vanillaExecutionStrategy.address, | |||
| [vanillaVotingStrategy.address], | |||
| ['0x2'], | |||
There was a problem hiding this comment.
looking at those 0x0, 0x1, 0x2, it might be a good idea to declare a variable latestIndex and increment it and use it when need be? Might make working with this code easier in the future
There was a problem hiding this comment.
feels like a lot of effort right now lol, will defo do that for the starknet.js scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of indexing by voting strategy address, we now index by a unique number instead. The benefit of this is that it allows a space to register multiple instances of the same strategy (but with different parameters)
closes #163