Session key auth #296
Merged
Session key auth #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pscott
requested changes
Sep 20, 2022
pscott
reviewed
Sep 22, 2022
| ): | ||
| SessionKey_owner_store.write(session_public_key, eth_address) | ||
| let (current_timestamp) = get_block_timestamp() | ||
| SessionKey_end_timestamp_store.write(session_public_key, current_timestamp + session_duration) |
There was a problem hiding this comment.
Should we check for overflow here? What happens if current_timestamp + session_duration overflows? the number will be either negative, or < current_timestamp? This means it simply won't work, so might as well throw an error here right?
There was a problem hiding this comment.
yeah nice spot. could also enforce a max session duration?
There was a problem hiding this comment.
Yeah I think a max duration of a year should be fine to start with, wdyt?
There was a problem hiding this comment.
I just put an overflow check for now, some people might just want an indefinite session key to be active so seems unnecessary to limit it.
with_attr error_message("Overflow in Session duration, use smaller value"):
assert_le(current_timestamp, end_timestamp)
end
pscott
approved these changes
Sep 22, 2022
pscott
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 2 session key authenticators, one authorized by an ethereum signature, and one authorized by an ethereum transaction.
closes #254